สอบถามความคิดเห็นระหว่างการเขียนฟังชั่นแบบซับซ้อนกับแบบง่าย ว่าอันไหนดีกว่าครับแต่การทำงานออกมาเหมือนกัน

$data_table     = 'country';
$data_fields            = array('id','Name','Population'); // or array('*');
$data_where_condition   = array('id<'=>'1000','Population>'=>'0','Population<'=>'1000');
$order_by               = "id";
$return_data_select = $object->getData($data_table,$data_fields,$data_where_condition,$order_by);

simpleGetData("select id,Name,Population from $data_table  where .... ");

    function getData($tableName,$data_fields,$whereCondition,$orderby)
    {   
        $this->where_str = NULL;
        foreach($whereCondition as $item => $value) 
        {
            $this->where_str .= "$item '$value' AND ";
        } 
        $this->where_str = @rtrim($this->where_str, ' AND ');
        if($data_fields=="*")
        {
            $data_fields = "*";
        }
        else
        {
            $data_fields = @ltrim(@implode(',',$data_fields)," ,");    
            //$data_fields = @implode(',',$data_fields);    
        }        
        
        $sql            = "SELECT $data_fields FROM $tableName WHERE $this->where_str ORDER BY $orderby";
        $result         = @mysql_query($sql) or die ("<h3>Error</h3><p><b>".@mysql_error()."</b></p>");
        $count_record   = @mysql_num_rows($result);
        if($count_record>0)
        {
            while($row = @mysql_fetch_assoc($result)) 
            {
                $data_array[] = $row;
            }
        }
        else
        {
            $data_array = "No record found...";
        }   
        @mysql_free_result($result);
        return $data_array;
     }

  function simpleGetData($sql)
   {
        $result = @mysql_query($sql) or die ("<h3>Error</h3><p><b>".@mysql_error()."</b></p>");
        $count  = @mysql_num_rows($result);
        if($count>0)
        {
            while($row = @mysql_fetch_assoc($result)) 
            {
                $data_array[] = $row;
            }
        }
        else
        {
            $data_array = "No record found...";
        }   
        @mysql_free_result($result);
        return $data_array;
   }